tools,tests: improve robustness of changelog script, add test for fips#412
Draft
Meulengracht wants to merge 10 commits intocanonical:core22from
Draft
tools,tests: improve robustness of changelog script, add test for fips#412Meulengracht wants to merge 10 commits intocanonical:core22from
Meulengracht wants to merge 10 commits intocanonical:core22from
Conversation
bboozzoo
reviewed
Mar 16, 2026
| with gzip.open(chl_path) as chl_fh: | ||
| return chl_fh.read().decode('utf-8') | ||
| else: | ||
| raise FileNotFoundError(f"no supported changelog found for package {pkg}") |
Contributor
There was a problem hiding this comment.
seems like other places use f strings
tools/generate-changelog.py
Outdated
| print(f"failed to resolve FIPS changelog for {pkg}/{new_v}") | ||
| raise KeyError | ||
| if re.match(r'.*\+esm[0-9]*$', new_v) or package_name(pkg) in pkg_no_changelog: | ||
| raise PackageNoChangelog('package ' + pkg + ' does not have changelog') |
| remote_url = subprocess.check_output(['git', 'remote', 'get-url', 'origin']).decode('ascii').strip() | ||
| if remote_url.startswith("git@github.com:"): | ||
| remote_url = remote_url.replace("git@github.com:", "https://github.com/") | ||
| return remote_url.removesuffix(".git") |
Contributor
There was a problem hiding this comment.
this needs python 3.9 IIRC, so it should work on 22.04
.github/workflows/tests.yaml
Outdated
| artifact_file: core22.artifact | ||
| - variant: fips | ||
| artifact_name: core-fips-snap | ||
| artifact_file: core22-fips.artifact |
Contributor
There was a problem hiding this comment.
do you have access to the PPA from github CI?
bboozzoo
approved these changes
Mar 16, 2026
tools/generate-changelog.py
Outdated
| return chl_fh.read().decode('utf-8') | ||
| else: | ||
| raise FileNotFoundError(f"no supported changelog found for package {pkg}") | ||
| raise FileNotFoundError("no supported changelog found for package " + pkg) |
Contributor
There was a problem hiding this comment.
this is still using + instead of f strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.