Skip to content

Support IPv6 addresses and CIDRs in DDoS allow lists - #670

Open
Thanhphan1147 with Copilot wants to merge 8 commits into
mainfrom
copilot/update-pydantic-validator-to-ipvanyaddress
Open

Thanhphan1147 with Copilot wants to merge 8 commits into
mainfrom
copilot/update-pydantic-validator-to-ipvanyaddress

Conversation

Copilot AI commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does

  • Accepts IPv4 and IPv6 addresses and CIDR blocks in the DDoS protection allow list.
  • Updates both the configurator library and HAProxy’s consumer copy, plus the configurator’s option description.
  • Example: ip-allow-list="2001:db8::1,2001:db8:abcd::/48"

Why we need it

IPv6-enabled HAProxy deployments need to allow-list clients using IPv6 addresses as well as IPv4.

Test plan

  • Unit coverage for IPv4/IPv6 addresses and CIDR blocks in the configurator and HAProxy library tests.

Review focus

  • Confirm the configurator and consumer library copies remain aligned. No new dependencies or breaking changes are introduced.

Checklist

  • I followed the contributing guide
  • I added or updated the documentation (if applicable)
  • I updated docs/changelog.md with user-relevant changes
  • I added a change artifact for user-relevant changes in docs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the label no-release-note.
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors

Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Copilot AI changed the title [WIP] Update pydantic validator for IPv6 support in haproxy-ddos-protection-configurator Support IPv6 addresses and CIDRs in DDoS allow lists Oct 6, 2026
Copilot AI requested a review from Thanhphan1147 October 6, 2026 09:32
@Thanhphan1147
Thanhphan1147 marked this pull request as ready for review October 6, 2026 10:29
@Thanhphan1147
Thanhphan1147 requested a review from a team as a code owner October 6, 2026 10:29
@@ -92,7 +92,7 @@ def _on_config_changed(self, event):
import logging
from collections.abc import MutableMapping

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would increase LIBPATCH ( otherwise remove it if we are not using it).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please bump the LIBPATCH version

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped LIBPATCH to 5 in both library copies in commit d72032e.

@Thanhphan1147

Copy link
Copy Markdown
Collaborator

[merge bot]: This PR is now being monitored to automatically rerun failing tests

@Thanhphan1147
Thanhphan1147 enabled auto-merge (squash) October 9, 2026 10:48
Thanhphan1147 and others added 2 commits October 9, 2026 12:48
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
auto-merge was automatically disabled October 9, 2026 10:49

Head branch was pushed to by a user without write access

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support IPv6 addresses / CIDRs in the haproxy-ddos-protection-configurator charm

4 participants