feat: More cross-track itest assertions#314
Draft
MichaelThamm wants to merge 6 commits intomainfrom
Draft
Conversation
MichaelThamm
commented
May 1, 2026
MichaelThamm
commented
May 1, 2026
MichaelThamm
commented
May 1, 2026
MichaelThamm
commented
May 8, 2026
| wait_for_active_idle_without_error([ca_model, cos_model]) | ||
| tls_ctx = get_tls_context(tmp_path, ca_model, "self-signed-certificates") | ||
| catalogue_apps_are_reachable(cos_model, tls_ctx) | ||
| assert not tf_manager.plan_has_changes(**jubilant_args) |
Contributor
Author
There was a problem hiding this comment.
We probably don't want this assertion and can say in docs to "run terraform apply until no more changes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
quality_gatemethod to keep the tests DRYSolution
Checklist
Context
Testing Instructions
Upgrade Notes