Skip to content

feat: Unit test for otelcol logs assertion#339

Open
MichaelThamm wants to merge 4 commits intomainfrom
feat/utest-otelcol-logs
Open

feat: Unit test for otelcol logs assertion#339
MichaelThamm wants to merge 4 commits intomainfrom
feat/utest-otelcol-logs

Conversation

@MichaelThamm
Copy link
Copy Markdown
Contributor

@MichaelThamm MichaelThamm commented May 8, 2026

Issue

Continuation on this PR:

Improve the regex with this one.

Solution

Add a unit test to assert that the regex is correctly parsing the otelcol logs.

You can run the unit tests with:

  1. just unit -> runs all pytest and TF unit tests
  2. just unit-pytest runs all pytest unit tests
  3. just unit-tf cos|cos-lite|cos-dev runs the TF unit tests for that specific module

Checklist

  • I have added or updated relevant documentation.
  • PR title makes an appropriate release note and follows conventional commits syntax.
  • Merge target is the correct branch, and relevant tandem backport PRs opened.

@MichaelThamm MichaelThamm changed the title chore feat: Unit test for otelcol logs assertion May 8, 2026
Co-authored-by: Copilot <copilot@github.com>
@MichaelThamm MichaelThamm marked this pull request as ready for review May 8, 2026 18:14
@MichaelThamm MichaelThamm requested a review from a team as a code owner May 8, 2026 18:14
Copy link
Copy Markdown
Contributor

@sinapah sinapah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think the unit test is not being triggered? Should we change the workflow YAML file to run the just recipe for this unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants