feat: Unit test for otelcol logs assertion#339
Open
MichaelThamm wants to merge 4 commits intomainfrom
Open
Conversation
sinapah
reviewed
May 8, 2026
Contributor
sinapah
left a comment
There was a problem hiding this comment.
Looks good, but I think the unit test is not being triggered? Should we change the workflow YAML file to run the just recipe for this unit test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Continuation on this PR:
Improve the regex with this one.
Solution
Add a unit test to assert that the regex is correctly parsing the otelcol logs.
You can run the unit tests with:
just unit-> runs all pytest and TF unit testsjust unit-pytestruns all pytest unit testsjust unit-tf cos|cos-lite|cos-devruns the TF unit tests for that specific moduleChecklist