feat: sync operator app skeleton - #16
Open
sadiq1971 wants to merge 3 commits into
Open
Conversation
sadiq1971
changed the title
sadiq1971
force-pushed
the
feat/sync-operator-node
branch
from
August 19, 2026 22:46
dea0d60 to
bf74782
Compare
timwu20
reviewed
Aug 20, 2026
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
thanks, this looks mostly reasonable. I left a few comments. I would also suggest adding an integration test directly in this PR that tests that you can at least start and stop the app successfully.
sadiq1971
force-pushed
the
feat/sync-operator-node
branch
from
August 25, 2026 18:43
bc2b835 to
36c2ce1
Compare
sadiq1971
force-pushed
the
feat/sync-operator-node
branch
from
August 25, 2026 19:29
36c2ce1 to
681ff2f
Compare
Adds the apps/syncoperator module: config, store, automation host and health, ingesting the MemberTraffic purchases the operator observes for its own synchronizer and holding the sequencer admin connection the reconciliation will grant on. Ingestion is deliberately not filtered by the node's own migration id, since a registered synchronizer is pinned to migration id 0. Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
Drop the synchronizer id and sequencer list from the config and take the synchronizer id from the sequencer instead. Share the MemberTraffic sum query with the DSO store. Also fixes the store test, which never ran: the operator was missing as an observer on the ingested contracts, and the suite was absent from the non-integration test list. Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
sadiq1971
force-pushed
the
feat/sync-operator-node
branch
from
August 25, 2026 19:48
681ff2f to
75cbcb9
Compare
Add package_name to the sync_operator_acs_store index, matching the shape V049 rebuilt the dso and scan indexes into; the shared MemberTraffic query filters on it. Drop trafficBalanceReconciliationDelay, which nothing reads, and the scalapb runtime deps, which the module has no generated code for. Add the module to clean-splice. Signed-off-by: sadiq1971 <sadiqurr8@gmail.com>
Collaborator
Author
I have addressed the comments. For integration test I have added it on PR #17 to keep this PR clean and less changes. |
moritzkiefer-da
approved these changes
Aug 26, 2026
| ) extends SpliceAppAutomationService( | ||
| automationConfig, | ||
| clock, | ||
| // Nothing registered here depends on domain time yet. |
There was a problem hiding this comment.
Suggested change
| // Nothing registered here depends on domain time yet. | |
| // Nothing registered here depends on domain time. |
| } | ||
| // Only used to partition the store's ingestion offsets; purchases are ingested regardless | ||
| // of it, see SyncOperatorStore.contractFilter. | ||
| domainMigrationId <- appInitStep(s"Resolving domain migration id") { |
There was a problem hiding this comment.
I don't understand why you need this here, there is no migration id for dedicated synchronizers/it's always zero?
| config.automation.ingestion, | ||
| config.parameters.defaultLimit, | ||
| ) | ||
| globalSynchronizerId <- appInitStep("Get the decentralized synchronizer id") { |
There was a problem hiding this comment.
Suggested change
| globalSynchronizerId <- appInitStep("Get the decentralized synchronizer id") { | |
| globalSynchronizerId <- appInitStep("Get the global synchronizer id") { |
| metrics.grpcClientMetrics, | ||
| retryProvider, | ||
| ) | ||
| synchronizerId <- appInitStep("Get the synchronizer id from the sequencer") { |
There was a problem hiding this comment.
probably a good idea to log the synchronizer id. If you use retryProvider.getValue it does that for you and you get retries for this
| ), | ||
| ) | ||
|
|
||
| lazy val `apps-syncoperator` = |
There was a problem hiding this comment.
add it to the list of things that cleaned out by splice-clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
apps/syncoperatormodule, modelled onapps/splitwell: config, store, automation host, metrics, bootstrap, health.SyncOperatorStoreingestsMemberTrafficwhere this operator is the observer, and exposesgetTotalPurchasedMemberTraffic(member)off an indexed column. The query itself is now shared withDbSvDsoStoreviaMemberTrafficQueries.SyncOperatorAppconnects to Scan and its own sequencer, and takes its synchronizer id from that sequencer rather than from config, so there is nothing to keep in sync at bootstrap.sync_operator_acs_storetable and twoSpliceDbLockCounters.How it's verified
compile,Test/compileandscalafmtCheckAllpass across the tree.SyncOperatorStoreTestcovers the filter: sums across purchases, keeps members apart, and ignores purchases for another synchronizer, another operator, no operator, and a non-zero migration id. 7/7 pass locally against Postgres, and it is now listed intest-full-class-names-non-integration.logso CI runs it.Not covered: that the store survives a decentralized-synchronizer migration without dropping records. That is part of the acceptance for canton-network#35 and needs a fixture that changes the migration id mid-test.
Tracked in
Implements P2-E5.2. Unblocks P2-E5.3, which also needs P2-E5.1 (#15 here). Relies on the migration-id policy in P2-E1.5.