Skip to content

Use DbStorage.toInClause and remove inClause - #6963

Open
mrdziuban wants to merge 1 commit into
canton-network:mainfrom
obsidiansystems:mrdziuban/toInClause/3900
Open

Use DbStorage.toInClause and remove inClause#6963
mrdziuban wants to merge 1 commit into
canton-network:mainfrom
obsidiansystems:mrdziuban/toInClause/3900

Conversation

@mrdziuban

@mrdziuban mrdziuban commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #3900

Best viewed with whitespace changes ignored: https://github.com/canton-network/splice/pull/6963/changes?w=1

I checked every spot toInClause is now used to verify that the lack of a leading space I mentioned is not a problem -- all of the queries already added a space before appending the result of the call to inClause.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Fixes canton-network#3900

Removes `inClause` in favor of `DbStorage.toInClause`.

Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use toInClause from canton once it is available from fork

5 participants