[Misc] Add support for configurable application version in chart#92
[Misc] Add support for configurable application version in chart#92anirudhprasad-sap merged 2 commits intomainfrom
Conversation
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The core issue is already captured in the comment posted on lib/util.js line 321.
Summary: The PR correctly adds app.version support for GitOps/Argo CD scenarios, with proper schema updates across both chart variants and consistent test fixture updates. However, there is one significant logic defect: the capApplicationVersionName helper template (which sets the Kubernetes resource name) always uses .Release.Revision, while spec.version now uses app.version when set. This mismatch means that in the GitOps use case this feature targets, the resource name won't reflect the custom version string, undermining the feature's usefulness and potentially confusing the CAP operator.
PR Bot Information
Version: 1.20.27
- Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
91769240-ad57-4473-bb5e-e77b38ba033b
|
2 participants
Fix for #91