[Misc] GlobalAccountId to ProviderSubaccountId migration + Readme update#98
Merged
anirudhprasad-sap merged 8 commits intomainfrom Apr 29, 2026
Merged
[Misc] GlobalAccountId to ProviderSubaccountId migration + Readme update#98anirudhprasad-sap merged 8 commits intomainfrom
anirudhprasad-sap merged 8 commits intomainfrom
Conversation
…iles Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…dd migration instructions and default values Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
The PR introduces a globalAccountId → providerSubaccountId migration and a guard for empty chart directories, but has several issues worth addressing: a misspelled method name (adoptIncompactibleChanges), a potentially confusing early-exit guard that silently conflates "btp absent" with "globalAccountId absent", a missing warning when the CRO template file doesn't exist but the schema is still overwritten, and a subtle fragility around double-writing values.schema.json during migration. The bare readdirSync('chart') path is also safer when anchored to cds.root.
PR Bot Information
Version: 1.20.33
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - File Content Strategy: Full file content
- Correlation ID:
3e2f169e-aad6-4495-a0a9-33f346f62e7d
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Migrate
globalAccountIdtoproviderSubaccountIdin CAP Operator Helm ChartsNew Feature
♻️ Refactor/Migration: Introduced an automatic migration mechanism that detects and replaces the deprecated
globalAccountIdfield withproviderSubaccountIdin existing CAP Operator Helm chart files when runningcds add cap-operator.Changes
lib/add.js:adoptIncompactibleChanges()method that detects ifbtp.globalAccountIdstill exists inchart/values.yamland automatically migrates it toproviderSubaccountId, updateschart/templates/cap-operator-cros.yamlif present, and refreshesvalues.schema.jsonfrom the plugin's bundled templates.handleExistingChart()so it runs automatically when re-runningcds add cap-operatoron an existing chart.chartdirectory is non-empty before treating it as an existing chart.test/add.test.js:globalAccountId→providerSubaccountIdin a simple chart.PR Bot Information
Version:
1.20.33pull_request.opened3e2f169e-aad6-4495-a0a9-33f346f62e7danthropic--claude-4.6-sonnet