Skip to content

setUserId accept null too #49#50

Open
markxoe wants to merge 3 commits into
capacitor-community:masterfrom
markxoe:master
Open

setUserId accept null too #49#50
markxoe wants to merge 3 commits into
capacitor-community:masterfrom
markxoe:master

Conversation

@markxoe

@markxoe markxoe commented Feb 16, 2021

Copy link
Copy Markdown

I've solved #49 so that null will be accepted by setUserId and in the web-version it gets converted to an empty string

@MNorgren

Copy link
Copy Markdown

Any update on this PR? I am also waiting on this fix

@brownoxford

Copy link
Copy Markdown
Member

I have some time set aside later this week for this.

@edouardruiz

Copy link
Copy Markdown

Hi, I also need to unset the userId via setUserId. @brownoxford do you think you need help to merge this PR?

@sergeivoroshilov

Copy link
Copy Markdown

@brownoxford @edouardruiz any updates?

@sneko

sneko commented May 23, 2022

Copy link
Copy Markdown

Also interested by this. Any news @brownoxford?

@sneko

sneko commented May 23, 2022

Copy link
Copy Markdown

@markxoe it seems your PR is not fixing the issue unfortunately. For example on iOS:

if let userId = call.getString("userId") {
Analytics.setUserID(userId)
call.resolve()
} else {
call.reject("userId property is missing")

Since it expects a "string" it will raise an error in all cases. Did you test your implementation? (maybe I'm doing something wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants