Assert in travels #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanHenke
reviewed
Dec 1, 2025
| @assert: (case | ||
| when BeginDate > EndDate | ||
| then 'End Date must be after Begin Date.' | ||
| when Bookings.Flight.date < BeginDate |
There was a problem hiding this comment.
@rjayasinghe: The check "flight date is within the travel time" we already had with @assert.constraint in a separate annotation on the Bookings entity. It´s nice to integrate it here. The only thing I´m wondering is: what happens if you add a new Booking, is this assert properly validated? Probably not a patch draft, but hopefully on the draft activate
StefanHenke
reviewed
Dec 1, 2025
| Description; | ||
| } | ||
|
|
||
| annotate my.Bookings with { |
There was a problem hiding this comment.
Something that we had in the past already and that I have tested as well:
annotate my.Booking : ConnectionID with @assert: (case when to_Flight.OccupiedSeats >= to_Flight.MaximumSeats then 'no free seats on selected flight' end);
Collaborator
|
Replaced by #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.