test(persist): interactive run without --ephemeral creates .harness/<agent>/ persistence dir#23
Merged
capotej merged 1 commit intocapotej:mainfrom Apr 27, 2026
Conversation
…agent>/ persistence dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an e2e test that locks the boundary in the interactive + non-ephemeral branch of
run():-p, no piped stdin)--ephemeralflagIn that branch the CLI is required to materialize the persistence dirs that the active adapter advertises via
persistMounts()and pass them as-vmounts. For thepiadapter that means creating<cwd>/.harness/pi/and emitting a-v <host>:/home/harness/.pi/agentmount.Why
This is the inverse of the two existing implicit-ephemeral tests (
-pand piped stdin) — both assert that.harness/is not created. Nothing currently asserts the positive case, so a future refactor that flipseffectiveEphemeralor drops thefs.mkdirSync()call would slip through CI.The branch is only reachable when
process.stdin.isTTY === true, so the test allocates a PTY via util-linuxscript(same approach as the existingpi: interactive ... no -ptest merged in #5/#22). Self-skips on platforms withoutscript.How verified
Net diff:
+1 testintests/e2e/cli.test.mjs.