Fix incorrect array sizes in Java binding: regs_read and regs_write - #3056
Closed
PAX523 wants to merge 1 commit into
Closed
Fix incorrect array sizes in Java binding: regs_read and regs_write#3056PAX523 wants to merge 1 commit into
regs_read and regs_write#3056PAX523 wants to merge 1 commit into
Conversation
Author
|
Perhaps, not required anymore, since #2904 updates the Java bindings completely? |
Rot127
reviewed
Aug 31, 2026
Collaborator
There was a problem hiding this comment.
These changes won't be enough. The API changed a lot from v5 to the current next/v6.
To get a feeling for all the additions and changes see https://github.com/capstone-engine/capstone/blob/next/docs/cs_v6_release_guide.md
I agree with you that #2904 is the way to go for now.
I would close it due to this.
If you still see a point in it, please let me know. We can of course merge it if there is an edge case it solves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
See this issue for the 5 release: #3054
...
Test plan
Leverage the Java binding and disassemble x86 opcodes
...
Closing issues
N/A
...