Skip to content

Fix incorrect array sizes in Java binding: regs_read and regs_write - #3056

Closed
PAX523 wants to merge 1 commit into
capstone-engine:nextfrom
PAX523:next
Closed

Fix incorrect array sizes in Java binding: regs_read and regs_write#3056
PAX523 wants to merge 1 commit into
capstone-engine:nextfrom
PAX523:next

Conversation

@PAX523

@PAX523 PAX523 commented Aug 31, 2026

Copy link
Copy Markdown

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

See this issue for the 5 release: #3054

...

Test plan

Leverage the Java binding and disassemble x86 opcodes

...

Closing issues

N/A

...

@github-actions github-actions Bot added the java bindings label Aug 31, 2026
@PAX523

PAX523 commented Aug 31, 2026

Copy link
Copy Markdown
Author

Perhaps, not required anymore, since #2904 updates the Java bindings completely?

@Rot127 Rot127 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes won't be enough. The API changed a lot from v5 to the current next/v6.

To get a feeling for all the additions and changes see https://github.com/capstone-engine/capstone/blob/next/docs/cs_v6_release_guide.md

I agree with you that #2904 is the way to go for now.

I would close it due to this.
If you still see a point in it, please let me know. We can of course merge it if there is an edge case it solves.

@Rot127 Rot127 closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants