Repository navigation
chore: clear deferred review nits (error repr + two docstrings) - #84
Merged
Merged
Conversation
The three items noted in #77/#78 review threads as merged-code cleanups: - loader.py: quote mode_type and kind (repr) in the "not allowed for kind" error, matching the sibling "must be one of" error; test updated. - postgres adapter.py: ensure_table docstring port-signature ref 0.6.0 -> 0.8.0. - keys.py: ensure_unique_key docstring no longer claims first-appearance order for the repeated-key message; pyarrow grouping order is not contractual. Signed-off-by: Simone Carolini <simonecarolini.sc@gmail.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0137E9XmyUXhwPTRrtNfivDw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the three merged-code cleanups promised in #77/#78 review threads.
mode_type+kindquoted (repr) in the "not allowed for kind" error, matching the sibling error; test updatedensure_tableport-signature ref 0.6.0 → 0.8.0ensure_unique_keydrops the "first appearance" order claim (pyarrow grouping order is not contractual)No behavior change beyond the quoted error text. 287 contract/loader tests pass; ruff + mypy clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_0137E9XmyUXhwPTRrtNfivDw