feat: add getCacheTags() method to replace direct property access#29
Merged
jwadhams merged 1 commit intodevelopmentfrom Apr 2, 2026
Merged
feat: add getCacheTags() method to replace direct property access#29jwadhams merged 1 commit intodevelopmentfrom
jwadhams merged 1 commit intodevelopmentfrom
Conversation
Implementers can now override getCacheTags() to derive tags from other properties rather than setting state in the constructor. The property remains as the default backing store but is no longer accessed directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwadhams
force-pushed
the
get-cache-tags-method
branch
from
1fb3bdf to
1a6e2dd
Compare
dichowie
reviewed
Apr 2, 2026
dichowie
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCacheTags(): arraytoAbstractRequest, returning$this->cacheTagsby defaultAbstractRequestandAbstractUseStaleRequestnow go throughgetCacheTags()instead of the property directlyRequestClassAssertionsupdated to call$request->getCacheTags()instead of thegetPropertyreflection helperMotivation
It's a recurring pattern (e.g. carsdotcom/modern-retailing-shared#3591) for implementers to set
cacheTagsin the constructor, where the tags are really just derived from other properties — not independent state that needs to be serialized. ProvidinggetCacheTags()as the extension point lets future implementers simply override the method instead, keeping tags derived rather than stored.🤖 Generated with Claude Code