Open
Conversation
GCdePaula
force-pushed
the
feature/broadcaster
branch
2 times, most recently
from
15bfdc6 to
05a88ff
Compare
GCdePaula
force-pushed
the
feature/broadcaster
branch
from
05a88ff to
1ae02dc
Compare
stephenctw
reviewed
Mar 3, 2026
Collaborator
stephenctw
left a comment
stephenctw
left a comment
There was a problem hiding this comment.
Looks great! Just left one comment.
| for tx in txs { | ||
| let event = BroadcastTxMessage::from_offset_and_tx(next_offset, tx); | ||
| next_offset = next_offset.saturating_add(1); | ||
| if events_tx.blocking_send(event).is_err() { |
Collaborator
There was a problem hiding this comment.
When blocking_send fails, the worker returns Ok(()) instead of propagating the error. Was that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.