Repository navigation
tui: write .env, .gitignore and secrets/ next to the compose file - #4
Merged
Merged
Conversation
Secret conversion used to write .env, .gitignore and secrets/ into the shell's working directory. Compose resolves .env (project directory) and the file: paths of top-level secrets relative to the compose file, so opening ~/proj/compose.yaml from another directory scattered those files in the wrong place and left the stack broken. The model now remembers the directory of the compose file it is bound to (set on import and on successful save) and convertSecretCmd writes everything there. A session not yet bound to a file keeps the old behavior (working directory). Tests cover both strategies, the unbound fallback, and the binding on import/save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secret conversion used to write .env, .gitignore and secrets/ into the shell's working directory. Compose resolves .env (project directory) and the file: paths of top-level secrets relative to the compose file, so opening ~/proj/compose.yaml from another directory scattered those files in the wrong place and left the stack broken.
The model now remembers the directory of the compose file it is bound to (set on import and on successful save) and convertSecretCmd writes everything there. A session not yet bound to a file keeps the old behavior (working directory).
Tests cover both strategies, the unbound fallback, and the binding on import/save.
What changed
How to test
Checklist
make lint/npm run lintpassesmake test/npm testpasses