Skip to content

Move to GitHub Actions and NuGet Trusted Publishing#740

Open
304NotModified wants to merge 9 commits intocastleproject:masterfrom
304NotModified:github-actions-and-trusted-publishing
Open

Move to GitHub Actions and NuGet Trusted Publishing#740
304NotModified wants to merge 9 commits intocastleproject:masterfrom
304NotModified:github-actions-and-trusted-publishing

Conversation

@304NotModified
Copy link

@304NotModified 304NotModified commented Mar 9, 2026

Changes from @Romfos, #700:

New changes:

  • Updated artifact publishing
  • Enable NuGet Trusted Publishing
  • Fix casing of version parameter
  • Fix incorrect quotes in conditions

I know this PR has a bit more then strictly necessary, but all these things are just great changes and makes the build/setup beter to maintain (no old build scripts etc.). I will make sure it will be all tested well.

How to use:

image

Fixes #739, fixes #497
Supersedes #700, supersedes #669

@304NotModified 304NotModified marked this pull request as draft March 9, 2026 23:46
@304NotModified
Copy link
Author

304NotModified commented Mar 9, 2026

Test results

runs of latest commit on this PR: cd91f2a
All looks good to me! See details below.

6.0 preview release

How would 6.0 look like?

Looks all good:
image

All packages are valid and are determenistic, source link and release mode

image

6.0.1

How would a release after 6.0 look like?

Correct numbers:
image

Correct versions:
image

@304NotModified 304NotModified marked this pull request as ready for review March 10, 2026 00:00
@304NotModified
Copy link
Author

304NotModified commented Mar 10, 2026

This is ready for review. All tested with my fork :)

We could even merge this without finishing the trusted publishing in #739 (comment) - but of course we could not release without it.


- name: Push to NuGet.org
if: inputs.publish == 'true'
run: dotnet nuget push artifacts\*.nupkg --api-key ${{steps.login.outputs.NUGET_API_KEY}} --source https://api.nuget.org/v3/index.json --skip-duplicate No newline at end of file
Copy link
Author

@304NotModified 304NotModified Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changelog with new features, bug fixes, and migration to GitHub Actions.
Updated changelog to reflect changes in project structure and bug fixes.
Updated changelog with recent enhancements and bug fixes.
@304NotModified
Copy link
Author

304NotModified commented Mar 10, 2026

Ah! I was thinking, I could also test the condition. And there was a mistake, fixed it!

See failing push when publish=true
https://github.com/304NotModified/CastleCore/actions/runs/22881768288/job/66385937832

Requesting GitHub OIDC token from: https://run-actions-1-azure-eastus.actions.githubusercontent.com/153//idtoken/0374955a-3e4a-4b14-9425-a5d539a4cb0c/7f9fee3c-fc5d-54cc-a4b1-2cfc823c3d06?api-version=2.0&audience=https%3A%2F%2Fwww.nuget.org
Error: Token exchange failed (401): No matching trust policy owned by user 'castleproject' was found

@304NotModified 304NotModified mentioned this pull request Mar 10, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace AppVeyor with GitHub Actions & NuGet.org Trusted Publishing Move from AppVeyor to GitHub Actions

2 participants