Adding safeguard to clock resolution estimation (Issue 3180) - #3182
Open
superman15625 wants to merge 1 commit into
Open
Adding safeguard to clock resolution estimation (Issue 3180)#3182superman15625 wants to merge 1 commit into
superman15625 wants to merge 1 commit into
Conversation
… prevent bad_alloc
Author
|
The reason for the AppVeyor build fail is due to an InternalBenchmarkTest that does: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a limit to the variable "iter" in order to prevent the chances of bad_alloc errors on systems that have high resolution. The limit is currently at 100,000. The resolution calculation will be stopped when either "iter" has surpassed the limit, or the 500ms gap has passed. Furthermore, the code currently creates an TimePoint for each "iter" (the variable passed into resolution()), which can led to memory issues. Instead, this fix only stores the previous timestamp as that is what is needed to determine the delta on the fly.
GitHub Issues
This is a PR aimed to fix the issue #3180 where an user ran the benchmark on a system that was able to run over 1 million iterations in under 500ms, causing a bad_alloc exception due to the amount of TimePoint instantiations. First, I decided to implement the iteration limit, but then I realized that there wasn't a need to store every single TimePoint. As such, I decided to compute deltas by only storing the current and previous timestamp information.
This is my first pull request, so I won't jump the gun and say the issue is closed.
Thanks :)