Skip to content

Make mount_point argument positional in examples/simple.rs#659

Open
numbleroot wants to merge 3 commits intocberner:masterfrom
numbleroot:master
Open

Make mount_point argument positional in examples/simple.rs#659
numbleroot wants to merge 3 commits intocberner:masterfrom
numbleroot:master

Conversation

@numbleroot
Copy link

@numbleroot numbleroot commented Feb 25, 2026

Simple change to fix the TODO stated for CLI argument mount_point in examples/simple.rs: To make the argument positional, as is the case for the other examples. This is achieved simply by removing the #[clap(long, default_value = "")] line right above mount_point, as fields without attributes define positional arguments by default. And by adjusting the tests that use the simple example.

Thanks for building and maintaining this useful crate!

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8ad493e37

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// TODO: make positional like other examples.
/// Act as a client, and mount FUSE at given path
#[clap(long, default_value = "")]
mount_point: String,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve --mount-point compatibility for simple example

Making mount_point positional here removes the --mount-point flag that existing repo tooling still uses, so those invocations now fail argument parsing before mount starts (for example fuser-tests/src/commands/simple.rs:31-37, fuser-tests/src/commands/mount.rs:247, fuser-tests/src/experimental.rs:161, and tests/bsd_pjdfs.sh:21 all pass --mount-point). This commit therefore breaks the current test/scripts workflow unless all callers are updated in lockstep or a compatibility alias is kept.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant