Repository navigation
fix(pr-review-toolkit): stop collector review misattribution - #112
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cblecker/claude-plugins/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused mitigation, documentation, and patch version bump are internally consistent.
Review effort: Balanced
Findings: None
What changed in this PR
Mitigates collector misattribution of submitted reviews during follow-up detection.
Changes:
- Strengthens review filtering and record-mapping instructions.
- Raises collector effort from low to high.
- Bumps the plugin patch version and updates design documentation.
| File | Description |
|---|---|
review-pr.js |
Hardens collector behavior and increases effort. |
DESIGN_NOTES.md |
Documents the new collector effort. |
plugin.json |
Bumps version to 2.5.1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
At low effort the review collector skipped the login filter and relabelled bot reviews with the reviewer's login, which turned on follow-up mode and demoted findings. Raise its effort and make it re-check each review's user.login before returning. Assisted-by: LLM
acb1186 to
70ffdb8
Compare
Summary
haiku/low) received twocoderabbitai[bot]reviews fromget_reviews. It returned them as three records withauthorset to the reviewer's login: it skipped the login filter and split one review into two records. That switched on follow-up mode with HEAD as the reviewed commit, so the delta was empty and non-critical findings were demoted as "unchanged since your review."effort: 'high'instead of'low'.get_reviewsinstructions now say to copyauthorverbatim fromuser.loginand to return one record per review. They also require a re-check against the tool result that drops any review whoseuser.loginisn't an exact match. Bots never match, and an emptyreviewslist is the normal result.This change reduces the chance of misattribution but adds no deterministic provenance check: JS still trusts the collector's
author.Test plan
node --check)claude plugin validate ./pr-review-toolkituvx skillsaw --strictDESIGN_NOTES.mdThis PR was written in part with the assistance of generative AI.