Skip to content

fix(pr-review-toolkit): stop collector review misattribution - #112

Merged
cblecker merged 1 commit into
mainfrom
fix/review-collector-attribution
Oct 2, 2026
Merged

cblecker merged 1 commit into
mainfrom
fix/review-collector-attribution

Conversation

@cblecker

@cblecker cblecker commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • In a review of Breakout bigquery ci data plugin openshift-eng/ai-helpers#786, the review collector (requested as haiku/low) received two coderabbitai[bot] reviews from get_reviews. It returned them as three records with author set to the reviewer's login: it skipped the login filter and split one review into two records. That switched on follow-up mode with HEAD as the reviewed commit, so the delta was empty and non-critical findings were demoted as "unchanged since your review."
  • The collector now runs at effort: 'high' instead of 'low'.
  • The get_reviews instructions now say to copy author verbatim from user.login and to return one record per review. They also require a re-check against the tool result that drops any review whose user.login isn't an exact match. Bots never match, and an empty reviews list is the normal result.
  • Bumps pr-review-toolkit to 2.5.1 and updates the design note on collector effort.

This change reduces the chance of misattribution but adds no deterministic provenance check: JS still trusts the collector's author.

Test plan

  • Workflow script parses (body wrapped in an async function, node --check)
  • claude plugin validate ./pr-review-toolkit
  • uvx skillsaw --strict
  • markdownlint on DESIGN_NOTES.md

This PR was written in part with the assistance of generative AI.

Copilot AI balanced review requested due to automatic review settings October 2, 2026 02:42
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: cblecker/claude-plugins/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: f9593486-8411-4c50-a37b-1c7f21546b23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused mitigation, documentation, and patch version bump are internally consistent.

Review effort: Balanced
Findings: None

What changed in this PR

Mitigates collector misattribution of submitted reviews during follow-up detection.

Changes:

  • Strengthens review filtering and record-mapping instructions.
  • Raises collector effort from low to high.
  • Bumps the plugin patch version and updates design documentation.
File Description
review-pr.js Hardens collector behavior and increases effort.
DESIGN_NOTES.md Documents the new collector effort.
plugin.json Bumps version to 2.5.1.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 2, 2026 02:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused mitigation, documentation, and patch version bump are consistent and complete.

Review effort: Balanced
Findings: None

At low effort the review collector skipped the login filter and
relabelled bot reviews with the reviewer's login, which turned on
follow-up mode and demoted findings. Raise its effort and make it
re-check each review's user.login before returning.

Assisted-by: LLM
@cblecker
cblecker force-pushed the fix/review-collector-attribution branch from acb1186 to 70ffdb8 Compare October 2, 2026 02:46
@cblecker
cblecker merged commit bacd8ec into main Oct 2, 2026
14 checks passed
@cblecker
cblecker deleted the fix/review-collector-attribution branch October 2, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants