Adds an iterate method that returns a (Async)Generator#29
Open
theSherwood wants to merge 2 commits intoccorcos:masterfrom
Open
Adds an iterate method that returns a (Async)Generator#29theSherwood wants to merge 2 commits intoccorcos:masterfrom
iterate method that returns a (Async)Generator#29theSherwood wants to merge 2 commits intoccorcos:masterfrom
Conversation
Owner
|
This is cool! Particulatly for reducing memory pressure when computing over a lot of data. That said, I am in the process of refactoring / rewriting this whole library so I don't exactly want to spend my time right now reviewing this PR and getting it merged... Let me return to this in a few weeks. |
Author
|
No problem! I saw you have the |
Owner
|
Poke around over here if you're interested 😄 https://github.com/ccorcos/database-experiments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you have a use for this, but there have been a few occasions using this library when I've wanted an
iterateinstead of ascan. So this adds PR adds an iterate method both to sync and async clients and store wrappers. I've also added a handful of tests (that are basically just copies of the scan tests). I have not done any checks with respect to reactivity anditerate, however.Thoughts?