Skip to content

fix: handle empty children in box_dots setitem #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santhreal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle empty children in box_dots setitem #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion box/box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,8 @@ def __setitem__(self, key, value):
if hasattr(self[first_item], "__setitem__"):
return self[first_item].__setitem__(children, value)
elif self._box_config["default_box"]:
if children[0] == "[":
# children may be "" for trailing dots (e.g. "a."); treat as Box + empty key.
if children[:1] == "[":
super().__setitem__(first_item, box.BoxList(**self.__box_config(extra_namespace=first_item)))
else:
super().__setitem__(
Expand Down
3 changes: 2 additions & 1 deletion box/box_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ def __setitem__(self, key, value):
return super().__setitem__(pos, value)
children = key[len(list_pos.group()) :].lstrip(".")
if self.box_options.get("default_box"):
if children[0] == "[":
# children may be "" after a trailing dot on a list path (e.g. "[0].").
if children[:1] == "[":
super().__setitem__(pos, box.BoxList(**self.box_options))
else:
super().__setitem__(pos, self.box_options.get("box_class")(**self.box_options))
Expand Down
11 changes: 11 additions & 0 deletions test/test_box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,17 @@ def test_set_default_box_dots(self):
assert t == Box(a=1, b=[1, 2])
assert t.setdefault("c", [{"d": 2}]) == BoxList([{"d": 2}])

def test_box_dots_trailing_dot_default_box(self):
# Trailing dots leave an empty children segment; must set empty-string key, not IndexError.
b = Box(default_box=True, box_dots=True)
b["a."] = 1
assert b["a"][""] == 1
b2 = Box(default_box=True, box_dots=True)
b2["a[0]."] = 2
assert b2.a[0][""] == 2
b3 = Box(default_box=True, box_dots=True)
assert isinstance(b3[".."], Box)

def test_from_json_file(self):
bx = Box.from_json(filename=data_json_file)
assert isinstance(bx, Box)
Expand Down