changes - #1831
Merged
Merged
Conversation
pendingintent
approved these changes
Aug 19, 2026
pendingintent
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and all tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and correctness of the
Distinctoperation, especially in handling empty datasets and grouped operations. It also adds comprehensive unit tests to cover these scenarios. The main changes are as follows:Enhanced Handling of Empty Datasets in Grouped Operations
Distinctoperation now correctly returns an empty grouped result with the appropriate columns when the input dataset is empty or when a filter produces zero rows, instead of failing or returning incorrect results. This is achieved by adding the_build_empty_grouped_resulthelper method and updating the execution logic to use it as needed. [1] [2] [3]Improved Reference Column Handling
_check_column_exists_in_datasetfunction and its usage were updated to allow the referenced domain column name to be configurable (defaulting to"RDOMAIN"), increasing flexibility for different dataset schemas. [1] [2] [3]Bug Fix in Result Expansion
_expand_operation_results_in_groupingto handle the case when an operation column is empty, preventing errors during result expansion.Testing Improvements
Distinctoperation for both empty datasets and filtered grouped results that yield zero rows, for both Pandas and Dask backends.Test Infrastructure
pandasimport in the test file to support new test cases.PR addresses attached issue. I updated SCheduleDecisionInstance in the test data for core-000804 to test;
this produces a scheduledesicioninstance with no timing instance
worth noting: conditionAssignments is cast as a bool and the current data in the repo is not able to be cast as such since it is a string
I also tested CORE-000712 given it's distinct-specific operation logic