fix: refactor kotlin process collection to a shared core component - #83
Merged
cdsap merged 1 commit intoAug 28, 2026
Merged
Conversation
cdsap
deleted the
issue/82-hermes-refactor-kotlin-process-collection-t-a1
branch
August 28, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
src/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.ktandsrc/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktboth directly instantiateConsolidateProcessesand know that the parser must useTypeProcess.Kotlin. That duplicates core Kotlin-process collection behavior inside two delivery paths: console reporting and Develocity reporting.Why this matters
Keeping the collection rule embedded in infrastructure adapters makes future parser changes easier to apply inconsistently and makes the reporting paths harder to test independently from process consolidation.
Proposed change
Introduce one small shared component, for example
KotlinProcessCollector, that accepts thejStatandjInfoproviders or raw strings and returns the consolidated KotlinProcesslist. Update both console and Develocity paths to call it, preserving current output and Build Scan values.Notes
From a clean architecture lens, process collection is core behavior while console output and Develocity Build Scan publishing are adapters. This refactor keeps the boundary small without changing public plugin behavior.
Fixes #82
Changes
src/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollector.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollectorTest.ktVerification
./gradlew ktlintCheck./gradlew test