fix: refactor kotlin process collection to isolate process parsing - #87
Merged
cdsap merged 1 commit intoAug 30, 2026
Merged
Conversation
Owner
Author
|
@cdsap PR Judge blocked this PR for manual review. State: The judge will not auto-merge this PR until the risky diff is reviewed manually. |
cdsap
deleted the
issue/86-hermes-refactor-kotlin-process-collection-t-a1
branch
August 30, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Both
src/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.ktandsrc/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktdirectly constructConsolidateProcessesand passTypeProcess.Kotlin. That duplicates the core rule for turning jstat/jinfo output into Kotlin process data across the console and Develocity infrastructure paths.Why this matters
The plugin has two reporting adapters, but the domain behavior of collecting Kotlin process data is embedded in both. Any future change to parser usage, process type selection, empty-output handling, or test doubles has to be coordinated in multiple Gradle-facing classes.
Proposed change
Introduce a small Kotlin-process collector, for example
KotlinProcessCollector, that accepts the jstat and jinfo strings and returnsList<Process>. Use it fromInfoKotlinProcessBuildService.close()andDevelocityWrapperConfiguration.processes(...), preserving the existing providers, reporting behavior, and output formatting.Notes
Clean architecture lens: this separates the core use case of deriving Kotlin process records from infrastructure adapters that decide where the records are reported.
Fixes #86
Changes
src/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessPlugin.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollector.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessPluginTest.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollectorTest.ktVerification
./gradlew ktlintCheck./gradlew test