fix: refactor process collection to a shared kotlin process collector - #89
Merged
cdsap merged 1 commit intoSep 1, 2026
Merged
Conversation
cdsap
deleted the
issue/88-hermes-refactor-process-collection-to-a-sha-a1
branch
September 1, 2026 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Kotlin process discovery is duplicated in two infrastructure paths:
src/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.kt:21-27consolidates jstat/jinfo provider output for console reporting, whilesrc/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.kt:33-38repeats the sameConsolidateProcesses().consolidate(..., TypeProcess.Kotlin)call for Build Scan reporting.Why this matters
The core behavior of turning jstat/jinfo output into Kotlin process data is coupled to both Gradle BuildService lifecycle code and Develocity integration code. Any future change to process parsing, filtering, or error handling must be made in multiple places and is harder to test without exercising Gradle or Develocity wiring.
Proposed change
Introduce a small core helper, for example
KotlinProcessCollector, that accepts jstat and jinfo strings and returnsList<Process>using the existingConsolidateProcessescall. UpdateInfoKotlinProcessBuildServiceandDevelocityWrapperConfigurationto resolve their providers as they do today, then delegate only the consolidation step to this helper.Notes
From a clean architecture lens, this extracts the small domain operation, collecting Kotlin process facts from raw tool output, away from Gradle BuildService and Develocity adapter code while preserving the repository's current simple class-based style.
Fixes #88
Changes
src/main/kotlin/io/github/cdsap/kotlinprocess/DevelocityWrapperConfiguration.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/InfoKotlinProcessBuildService.ktsrc/main/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollector.ktsrc/test/kotlin/io/github/cdsap/kotlinprocess/KotlinProcessCollectorTest.ktVerification
./gradlew ktlintCheck./gradlew test