op-node: Reduce log level for finalized block check#434
Merged
palango merged 1 commit intocelo-rebase-16from Mar 25, 2026
Merged
op-node: Reduce log level for finalized block check#434palango merged 1 commit intocelo-rebase-16from
palango merged 1 commit intocelo-rebase-16from
Conversation
ezdac
approved these changes
Mar 25, 2026
ezdac
left a comment
There was a problem hiding this comment.
I'm not even sure what use there is for this log at all, especially in the generic fetcher method, just before returning an error.
I believe, that if at all, the log should be emitted in the caller, based on what it means for the caller.
In any case, this will significantly lower the current log noise we have.
Author
|
This was useful while building it, to see what requests are incoming. The function overrides |
Author
|
Failing CI is because I initially set the wrong target branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarntoDebugfor the "requested L1 block is beyond local finalized height" message inop-node/rollup/finalized/finalized.goWarnlevelFixes #425
Test plan
op-node/rollup/finalized/finalized_test.gocontinue to pass