Skip to content

op-node: Reduce log level for finalized block check#434

Merged
palango merged 1 commit intocelo-rebase-16from
fix/reduce-finalized-log-level
Mar 25, 2026
Merged

op-node: Reduce log level for finalized block check#434
palango merged 1 commit intocelo-rebase-16from
fix/reduce-finalized-log-level

Conversation

@palango
Copy link
Copy Markdown

@palango palango commented Mar 25, 2026

Summary

  • Reduces the log level from Warn to Debug for the "requested L1 block is beyond local finalized height" message in op-node/rollup/finalized/finalized.go
  • This message fires frequently during normal operation and is not actionable, making it noise at the Warn level

Fixes #425

Test plan

  • Existing tests in op-node/rollup/finalized/finalized_test.go continue to pass
  • Verify reduced log noise in staging environment

@palango palango changed the base branch from develop to celo-rebase-16 March 25, 2026 11:55
@palango palango requested a review from ezdac March 25, 2026 11:55
Copy link
Copy Markdown

@ezdac ezdac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure what use there is for this log at all, especially in the generic fetcher method, just before returning an error.

I believe, that if at all, the log should be emitted in the caller, based on what it means for the caller.

In any case, this will significantly lower the current log noise we have.

@palango
Copy link
Copy Markdown
Author

palango commented Mar 25, 2026

This was useful while building it, to see what requests are incoming.

The function overrides L1BlockRefByNumber and hides all non-confirmed blocks, so I think there are cases where this information might be useful.

@palango
Copy link
Copy Markdown
Author

palango commented Mar 25, 2026

Failing CI is because I initially set the wrong target branch.

@palango palango merged commit 8fa8206 into celo-rebase-16 Mar 25, 2026
62 of 64 checks passed
@palango palango deleted the fix/reduce-finalized-log-level branch March 25, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove verbose warning log in l1-finalized fetcher

2 participants