Repository navigation
do not merge 2 - #5711
Closed
sc979 wants to merge 3 commits into
Closed
do not merge 2#5711sc979 wants to merge 3 commits into
sc979 wants to merge 3 commits into
Conversation
Switch the secret scan to the custom gitleaks flow of centreon/security-tools#64 (SECU-gitleaks-custom branch), which scans every commit of the PR (the native gitleaks-action stops at 30) and resolves the commit range defensively. Assisted-by: Claude Code (claude-opus-5-5)
sc979
changed the title
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the secret scan from
gitleaks-analysis.yml@main(nativegitleaks-action) togitleaks-analysis.yml@SECU-gitleaks-custom, the custom flow under review incentreon/security-tools#64. The custom flow:
base..head). The native action reads only thefirst 30 PR commits from the API, so on this repository a PR with 145 commits had only 27 of
them scanned;
"invalid revision range" failures);
On a real runner (#5710, 5 runs), the install and scan steps take 1.6–2.1 s in total. The
native action's scan step takes 3–4 s on this repository.
Note:
SECU-gitleaks-customis a feature branch. Switch back to@mainoncecentreon/security-tools#64 is merged and before that branch is deleted.
Target version (i.e. version that this PR changes)
🤖 Generated with Claude Code