Disallow manual boolean conditions in admin form - #83
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65.
Boolean conditions are used as the internal on/off toggle, but the condition editor still accepted them. That makes the UI confusing because those entries are hidden from the flag detail table.
This change hides
booleanfrom the condition dropdown for normal create/edit flows, and it returns a clear validation error if someone submitscondition=booleandirectly. Existing boolean records can still be edited through their direct URL for backward compatibility.I also added test coverage for both form behaviors.
I ran
DJANGO_SETTINGS_MODULE=wagtailflags.tests.settings .venv/bin/django-admin test.