Skip to content

Do not stage APKINDEX files into the apko_image cache #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-scott wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not stage APKINDEX files into the apko_image cache #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apko/private/apko_image.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,16 @@ def _impl(ctx):

lockfile = ctx.attr.contents[OutputGroupInfo].lockfile.to_list()[0]
apks = ctx.attr.contents[OutputGroupInfo].apks
indexes = ctx.attr.contents[OutputGroupInfo].indexes
keyrings = ctx.attr.contents[OutputGroupInfo].keyrings

inputs = prepare_apko_config_in_workdir(workdir, ctx)

deps = [apks, keyrings, indexes]
# The APKINDEX files from the `indexes` output group are deliberately not
# staged. `apko build --lockfile` installs exactly the locked packages by
# URL and checksum and never reads an index, while the indexes themselves
# are live, unpinned downloads: including them made the action key depend
# on when the repository was fetched and defeated remote caching.
deps = [apks, keyrings]

supports_lockfile = versions.is_at_least("0.13.0", apko_info.version)
if supports_lockfile:
Expand Down
Loading