refactor(agent): converge runtime control, tool AOP, and timeline#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows up PR #62 by removing the parallel mechanisms left around the canonical Agent path:
AgentRuntimethe single owner of sessions, runs, cancellation, and drainingtool.call/tool.resultDomainEventplanepkg/tools/**to top-leveltools/**and document the minimum four-method extension path without adding a plugin frameworkSubagent sync/async/fork and scanner verifier/sniper lifecycle migration remain intentionally deferred so they can move together rather than adopt a partial lifecycle abstraction.
Commit structure
Each finding is isolated in a reviewable commit:
Compatibility notes
These breaks are intentional and documented in #68:
AgentEventtimeline JSONL is no longer acceptedCommandPayload.ToolCall/command.resultare not supportedpkg/tools/...totools/.../skill:<name>Verification
go test -race ./core/runner ./pkg/webagent ./pkg/agent ./pkg/commands ./pkg/aop -count=1pkg/webgo test ./pkg/web -skip E2E -count=1go test ./core/runner ./core/output ./pkg/tui ./pkg/webagent ./pkg/webproto ./pkg/web -skip E2E -count=1go test ./tools/... -run '^$'npm run buildgit diff --checkA full
go test ./...still hangs in the pre-existingpkg/webterminal E2E test; the package passes when that E2E test is skipped.Refs #68