Repository navigation
chore: make the benchmark image's cargo registry writable - #86
Merged
Merged
Conversation
COPY recreates /usr/local/cargo and /usr/local/rustup as root-only, so cargo couldn't download crates as the host uid. Also installs clippy and rustfmt, which the rust image leaves out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image from #85 copies Rust from the official image, but COPY recreates
/usr/local/cargoand/usr/local/rustupas root-only, so cargo couldn't download crates when the container runs as the host uid. A trial run hit this oncargo testand worked around it withCARGO_HOME=/tmp/cargo-home. This makes both dirs writable again, as the rust image does, and adds clippy and rustfmt, which the rust image leaves out.🤖 Generated with Claude Code