Skip to content

[codex] Harden Smart Agent GitHub Actions workflows#1

Open
chambear2809 wants to merge 2 commits into
mainfrom
feature/client-inventory-api-checks
Open

[codex] Harden Smart Agent GitHub Actions workflows#1
chambear2809 wants to merge 2 commits into
mainfrom
feature/client-inventory-api-checks

Conversation

@chambear2809
Copy link
Copy Markdown
Owner

Summary

  • Upgrade workflow checkouts to actions/checkout@v6 for Node 24-compatible action runtime.
  • Fail remote lifecycle jobs when Smart Agent emits JSON with "error": true, even if the command exits zero.
  • Verify Smart Agent service health after deploy and remove temporary deployment artifacts from target hosts.
  • Fix uninstall workflow dependencies so API checks and summaries reference the actual uninstall-batch job.
  • Add a small shell test for Smart Agent output error detection.

Validation

  • shellcheck .github/scripts/*.sh
  • bash .github/scripts/test-lib.sh
  • bash .github/scripts/test-create-batches.sh
  • bash .github/scripts/test-client-inventory-api.sh
  • jq empty openapi.json
  • yamllint .github/workflows/*.yml
  • go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/*.yml
  • git diff --check

Live Lab Notes

  • Runner smartagent-demo is online and idle.
  • smartagent.service is active on all configured target hosts.
  • Machine Agent install currently reports a Smart Agent extraction error for the bundled otel collector on three targets; with this change that condition will fail the workflow instead of being hidden as success.

@chambear2809 chambear2809 marked this pull request as ready for review April 29, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant