Fix on redundant pull request constraints#427
Merged
Conversation
Signed-off-by: Brandon Lam <brandonlam2030@gmail.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contents of this PR is ported from augurlabs/augur#3713 filed by @brandonlam2030
Description
The Pull Request model contains redundant checks on unique data. Since two table arguments perform the same checks on repo_id and pr_src_id, we can remove one to improve efficiency. This removes unnecessary database overhead by eliminating duplicate constraints.
This PR fixes #227
Notes for Reviewers
Signed commits