Skip to content

Added accepted change requests count metric - #476

Draft
MoralCode wants to merge 5 commits into
mainfrom
Khusi2005/accepted-change-requests-metric
Draft

MoralCode wants to merge 5 commits into
mainfrom
Khusi2005/accepted-change-requests-metric

Conversation

@MoralCode

@MoralCode MoralCode commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Note

This PR was ported from augurlabs/augur#3532 filed by @Khusi2005 because the contribution was deemed to still be useful.

Added an implementation for the "Accepted Change Requests" metric based on the CHAOSS definition.The metric aligns with existing PR metrics and supports filtering by time period, repository, submitter, and merger.

Description

  • Implements a new registered metric that counts accepted (merged) pull requests using Augur’s ingested GitHub data.
  • Supports optional filters for date range, repository, repository group, PR submitter, and PR merger.
  • Follows existing query patterns used in pull_request.py to ensure consistency with current metrics.
    This PR fixes Change Requests accepted metric API #477

Notes for Reviewers

  • This change has been tested locally.
  • Feedback and suggestions are welcome.

Signed commits

  • Yes, I signed my commits.

AI Disclosure Warning: This PR description draft was generated using ChatGPT.

Added an implementation for the "Accepted Change Requests" metric based on the CHAOSS definition.The metric aligns with existing PR metrics and supports filtering by time period, repository, submitter, and merger.

Signed-off-by: Khusi2005 <139037790+Khusi2005@users.noreply.github.com>
Update SQL query to use pull_request_events

Signed-off-by: Khusi2005 <139037790+Khusi2005@users.noreply.github.com>
…lso handled.

Signed-off-by: Khusi2005 <139037790+Khusi2005@users.noreply.github.com>
Signed-off-by: Khusi2005 <139037790+Khusi2005@users.noreply.github.com>
Added validation to ensure either repo_id or repo_group_id is provided.

Signed-off-by: Khusi2005 <139037790+Khusi2005@users.noreply.github.com>
@MoralCode

Copy link
Copy Markdown
Contributor Author

Porting mainly because @shlokgilda gave it a positive review previously.

This will need to be reviewed in depth to account for the new project name (CollectOSS). I noticed when porting that one of the database tables this depends on contained the augur name, and thus will break (as that column has been, or soon will be, renamed).

@MoralCode MoralCode changed the title Khusi2005/accepted change requests metric Added accepted change requests count metric Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Requests accepted metric API

2 participants