Conversation
Signed-off-by: Juan Pasutti <juanpasutti@gmail.com>
Contributor
awesome, thanks so much!
No need, I like your approach better (keeping the images small) - I didn't realize that we had basically two python interpereters in the image Also id love to invite you to join CHAOSS Slack in the #wg-collectoss-8knot channel - mostly jut cuz im curious how you found CollectOSS/what your interest is in the project (would love to do what I can to help you be successful in your own goals with this project!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Debian 11 (bullseye) reached end of life on Aug 31, so packages from
bullseye-securityreturn 404 and the backend image stops building.This moves both base images to Debian 12 (bookworm) and pins the interpreter uv resolves to.
The pin is needed because of the PATH set a few lines above:
/usr/bincomes first. On bullseye the systempython3was 3.9, so it never competed with the 3.11 the image ships in/usr/local/bin. On bookworm the systempython3is 3.11, it satisfies the3.11in.python-version, and uv picks it up:That interpreter has no development headers, and
psutil==5.8.0has no wheel for it, so it builds from source and fails.UV_PYTHON=/usr/local/bin/python3.11points uv at the interpreter the image already ships.Verified on
linux/amd64, building the image before and after the change:apt-get install, 33 of 111 packages 404 fromdebian-security/usr/local/bin/python3.11(3.11.16)This PR fixes #481
Notes for Reviewers
The build is fixed by this change, but the end-to-end jobs will still fail. That failure is separate and older: it also happens on
main, and the docker workflow has been red since start of August. The job reaches the 8 minute timeout waiting forQuerying committers count, which never gets logged becauserepo_info_modelraises on the GraphQL query before reaching it. I'll open a separate issue with the details rather than mix it into this PR.I see Fix/upgrade docker base bullseye to bookworm #489 is open for the same issue. I'll close this one if you prefer to go that route. The difference worth a look either way is
UV_PYTHONversus installingpython3-dev: both make the build pass, but the first points uv at the interpreter the image ships, while the second adds the headers for the Debian one that PATH resolves to first. Pinning keeps the image smaller and makes the interpreter explicit.Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? Claude
- How were these tools used? Analysis of the build and CI logs, verification builds on linux/amd64 with the unpatched Dockerfile as a control, and a draft of this description
- Did you review these outputs before submitting this PR? Yes, I found the root cause and verified the fix locally before opening the issue, and I reviewed and edited everything here