Validate all errors v2#156
Draft
dmartin35 wants to merge 3 commits into
Draft
Conversation
…rs at once Signed-off-by: David Martin <david@chaoiq.io>
…list of errors in message Signed-off-by: David Martin <david@chaosiq.io>
dmartin35
force-pushed
the
validate-all-errors-v2
branch
from
December 27, 2019 10:30
9123381 to
94cb7bc
Compare
…t (to provide more feedback rather than simple msg) Signed-off-by: David Martin <david@chaosiq.io>
dmartin35
force-pushed
the
validate-all-errors-v2
branch
from
December 27, 2019 11:21
94cb7bc to
bd14964
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 86.41% 86.95% +0.53%
==========================================
Files 23 24 +1
Lines 1627 1717 +90
==========================================
+ Hits 1406 1493 +87
- Misses 221 224 +3
Continue to review full report at Codecov.
|
Lawouach
marked this pull request as draft
July 6, 2020 12:23
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 86.45% 86.95% +0.50%
==========================================
Files 23 24 +1
Lines 1624 1717 +93
==========================================
+ Hits 1404 1493 +89
- Misses 220 224 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Lawouach
this is similar purpose as the previous PR, to validate all experiment file syntax and report all at once. This internal is though different.
This is mode advanced refactoring, that would be useful to display more information to the user than the error string. We could output the message, the field in error, the value being validated, as well as a path/location within the object structure.
This is done internally by Validation objects that shall be created by all validation functions, to append errors with all possible arguments, and return the list of errors. An error is now a dict with defined structure.
This PR is intended to be reviewed and chosen between the other one #155, before we continue any further
still to be done, is to add the path/location of each error.