Dialog tests and README rework (0.5.0) - #7
Merged
Merged
Conversation
…rn, not 1 turns; drop unused packRows
…otes; full notes kept in docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for the tabbed dialog, and the README rework. Ships as 0.5.0 with #6.
Tests
test/e2e/dialog.e2e.mjs(6 scenarios): real turns through the entry file, then each tab laid out as the entry file lays it out -- Turn (time split adds up, timeline per step, tools, generated tokens, engine grid), every tab fitting at 72/80/106/130 cells, Session (tools by time, "no tool calls", coverage, tokens), History (this session / all), and the spacing rule.test/dialog.test.mjs(7): bar arithmetic, share rounding, aligned columns, bar give-way, column-grid fallback, and the long-legend-name gap.Fixes
1 turn, not1 turns.packRows.README
main'sassets/; they render once this is merged).docs/measurement-notes.md, with the two points now out of date flagged at its top.npm testandtsc --noEmitpass.