Skip to content

add a regression test for the fractional canvas size #12293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HuzaifaChaudary wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

add a regression test for the fractional canvas size #12293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/specs/helpers.dom.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,25 @@ describe('DOM helpers tests', function() {
expect(canvas.style.height).toBe(`${chartHeight}px`);
});

it ('should stop reporting a change once a fractional size is applied', function() {
var chart = window.acquireChart({}, {
canvas: {
width: 300,
height: 150,
}
});

chart.width = 300.4;
chart.height = 150.2;

// the canvas keeps whole pixels only so a fractional size still has to settle
expect(helpers.retinaScale(chart, 2, true)).toBe(true);
expect(helpers.retinaScale(chart, 2, true)).toBe(false);

expect(chart.canvas.width).toBe(600);
expect(chart.canvas.height).toBe(300);
});

describe('getRelativePosition', function() {
it('should use offsetX/Y when available', function() {
const event = {offsetX: 50, offsetY: 100};
Expand Down