Fix issue #20 - #23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Tooltip and DatePicker components to use direct dkfds imports (with added TypeScript typings) instead of dynamically importing and caching DKFDS on window, improving type-safety and removing any usage.
Changes:
- Replace
window.DKFDS+ dynamic import usage with directdkfdsimports in Tooltip and DatePicker. - Add
@types/dkfdsas a dev dependency to enable typed DKFDS usage. - Tighten Tooltip’s imperative API typing (e.g., ensure
isShowing()always returns a boolean).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/Tooltip/Tooltip.tsx | Switches to direct dkfds Tooltip import and removes any usage for the instance reference. |
| src/components/DatePicker/DatePicker.tsx | Switches to direct dkfds datePicker import and removes window.DKFDS dynamic loading logic. |
| package.json | Adds @types/dkfds to support typed DKFDS imports. |
| package-lock.json | Locks @types/dkfds dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue text was pasted directly into co-pilot. Seems like a solid solution.