Skip to content

Fix issue #20 - #23

Merged
chcederquist merged 1 commit into
mainfrom
chcederquist/issue/20
May 25, 2026
Merged

Fix issue #20#23
chcederquist merged 1 commit into
mainfrom
chcederquist/issue/20

Conversation

@chcederquist

Copy link
Copy Markdown
Owner

Issue text was pasted directly into co-pilot. Seems like a solid solution.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Tooltip and DatePicker components to use direct dkfds imports (with added TypeScript typings) instead of dynamically importing and caching DKFDS on window, improving type-safety and removing any usage.

Changes:

  • Replace window.DKFDS + dynamic import usage with direct dkfds imports in Tooltip and DatePicker.
  • Add @types/dkfds as a dev dependency to enable typed DKFDS usage.
  • Tighten Tooltip’s imperative API typing (e.g., ensure isShowing() always returns a boolean).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/components/Tooltip/Tooltip.tsx Switches to direct dkfds Tooltip import and removes any usage for the instance reference.
src/components/DatePicker/DatePicker.tsx Switches to direct dkfds datePicker import and removes window.DKFDS dynamic loading logic.
package.json Adds @types/dkfds to support typed DKFDS imports.
package-lock.json Locks @types/dkfds dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/Tooltip/Tooltip.tsx
@chcederquist
chcederquist merged commit e86ca73 into main May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants