Converted to node:test and updated dependencies#141
Open
BranGuzmen wants to merge 8 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s rule/unit tests from Jest to Node’s built-in node:test runner, while also bumping the plugin’s major version and updating ESLint/TypeScript-ESLint dependencies and CI workflows to newer Node/Eslint versions.
Changes:
- Replaced Jest-based specs with
node:test-based specs and introduced a shared RuleTester factory (src/rule-tester.test.ts). - Updated dependencies/engines (major version bump) and adjusted scripts/workflows for
node --test+ coverage. - Applied broad formatting/line-wrapping changes across rules, specs, and internal helper utilities.
Reviewed changes
Copilot reviewed 70 out of 71 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| ts-init/typings.test.ts | Formatting updates to TypeScript fixture typings used by type-aware tests. |
| src/ts-tester.test.ts | Removed old TS RuleTester helper (Jest-era). |
| src/tester.test.ts | Removed old ESLint RuleTester helper (Jest-era). |
| src/rule-tester.test.ts | Added centralized RuleTester factories for node:test. |
| src/require-type-out-of-type-only-imports.ts | Formatting-only changes. |
| src/require-type-out-of-type-only-imports.spec.ts | Migrated spec to node:test + shared tester. |
| src/require-ts-extension-imports-exports.ts | Formatting-only changes. |
| src/require-ts-extension-imports-exports.spec.ts | Migrated spec to node:test module mocking + shared tester. |
| src/require-strict-assert.ts | Formatting-only changes. |
| src/require-strict-assert.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/require-service-call-response-declaration.ts | Updated imports to .ts extensions; formatting. |
| src/require-service-call-response-declaration.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/require-resolve-full-response.ts | Refactor/formatting inside rule create(); no functional intent indicated. |
| src/require-resolve-full-response.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/require-fixed-services-import.ts | Formatting-only changes. |
| src/require-fixed-services-import.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/require-assert-predicate-rejects-throws.ts | Formatting-only changes. |
| src/require-assert-predicate-rejects-throws.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/require-assert-message.ts | Formatting-only changes. |
| src/require-assert-message.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/regular-expression-comment.ts | Formatting-only changes. |
| src/regular-expression-comment.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/object-literal-response.ts | Formatting-only changes. |
| src/object-literal-response.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/no-wallaby-comment.ts | Formatting-only changes (regex/comment handling unchanged). |
| src/no-wallaby-comment.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/no-uuid.ts | Formatting-only changes. |
| src/no-uuid.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/no-util.ts | Formatting-only changes. |
| src/no-util.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-test-import.ts | Formatting-only changes. |
| src/no-test-import.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/no-status-code-assert.ts | Updated import to .ts + formatting. |
| src/no-status-code-assert.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-side-effects.ts | Formatting plus meta/schema adjustments. |
| src/no-serve-runtime.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-random-v4-uuid.ts | Formatting-only changes. |
| src/no-random-v4-uuid.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-legacy-service-typing.ts | Formatting plus meta/schema adjustments. |
| src/no-legacy-service-typing.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-enum.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-duplicated-imports.ts | Formatting-only changes. |
| src/no-duplicated-imports.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/no-card-numbers.ts | Formatting-only changes. |
| src/no-card-numbers.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/library/ts-tree.ts | Formatting-only changes. |
| src/library/tree.ts | Formatting-only changes. |
| src/library/format.ts | Formatting-only changes. |
| src/invalid-json-stringify.ts | Formatting-only changes. |
| src/invalid-json-stringify.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/index.ts | Import formatting/line wrapping. |
| src/file-path-comment.ts | Formatting-only changes. |
| src/file-path-comment.spec.ts | Migrated spec to node:test + shared ESLint tester. |
| src/aws/require-consistent-read.ts | Formatting plus slight rule wrapper restructuring. |
| src/aws/require-consistent-read.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/aws/require-aws-config.ts | Formatting plus minor logic cleanup in NewExpression reporting. |
| src/aws/require-aws-config.spec.ts | Migrated spec to node:test + shared TS tester. |
| src/aws/require-aws-bare-bones.ts | Formatting-only changes. |
| src/aws/is-aws-sdk-v3-used.ts | Formatting-only changes. |
| package.json | Major version bump; dependency updates; switch CI scripts from Jest to node --test; adjust lint ignores and engine/peer ranges. |
| eslint.config.mjs | Removed eslint-plugin-import usage; updated eslint-plugin-eslint-plugin config; added node:test-safe calls for no-floating-promises. |
| docs/rules/require-service-call-response-declaration.md | Formatting-only changes in docs example. |
| .github/workflows/coverage.yml | Updated coverage workflow to run node --test coverage and changed reporter inputs. |
| .github/workflows/ci.yml | Updated CI Node matrix versions. |
| .github/workflows/check-published-scheduled.yml | Adjusted schedule and removed manual dispatch trigger. |
| .github/workflows/check-pr-reviews.yml | Minor workflow step/name ordering tweak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Beta Published - Install Command: |
Contributor
Author
|
Publish-beta action is failing with a 403. Probably an old npm token |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142