Remove CoPilot and bots from review checks#101
Merged
Conversation
adcreare
changed the title
adcreare
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the PR review-checking logic to ignore GitHub bots (and Copilot) when determining whether all requested reviewers have completed their reviews, aligning with issue #100.
Changes:
- Filter
listRequestedReviewers()results to exclude bots/Copilot from the “outstanding reviewers” count. - Add a nock fixture + unit test for the Copilot/bot reviewer scenario.
- Bump package version to
4.0.3(and update lockfile accordingly).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/github-api/index.ts | Adds isHumanReviewer and filters requested reviewers before counting outstanding reviewers. |
| src/nocks/github.test.ts | Adds mocked /requested_reviewers response including a bot/Copilot reviewer. |
| src/github-api/index-reviews.spec.ts | Adds a test asserting Copilot/bot is ignored in outstanding reviewer counts. |
| package.json | Bumps package version from 4.0.2 to 4.0.3. |
| package-lock.json | Updates lockfile to match the new package version and current dependency metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+92
to
+102
| users: [ | ||
| { | ||
| login: 'bob', | ||
| type: 'User', | ||
| }, | ||
| { | ||
| login: 'Copilot', | ||
| type: 'Bot', | ||
| }, | ||
| ], | ||
| })); |
Contributor
Author
There was a problem hiding this comment.
Fixed, validate the other path in a test. This resolves the other comments too.
|
Coverage after merging remove-copilot-from-required into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #100