Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the import policy enforcement to no longer fully block the got package (per Issue #96), and adjusts tests and package versioning accordingly.
Changes:
- Remove
gotfrom thepackages-not-allowedsecurity block list. - Update the corresponding unit test to only assert
axiosis fully blocked. - Bump package version from
4.0.0to4.0.1(and update the lockfile).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/check-imports/packages-not-allowed.ts |
Removes got from the blocked package list. |
src/check-imports/packages-not-allowed.spec.ts |
Updates assertions to match the updated blocked list. |
package.json |
Bumps package version to 4.0.1. |
package-lock.json |
Updates lockfile version metadata; also includes broad changes requiring correction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
| }); | ||
| it('contains axios and got as fully blocked dependencies', async () => { | ||
| it('contains axios as fully blocked dependencies', async () => { |
There was a problem hiding this comment.
Test description says "contains axios as fully blocked dependencies" but the assertion checks a single dependency. Consider updating the wording to singular ("dependency") to match the behavior and avoid confusion when reading test output.
Suggested change
| it('contains axios as fully blocked dependencies', async () => { | |
| it('contains axios as a fully blocked dependency', async () => { |
jpolavar
changed the title
|
Coverage after merging remove-got-not-allowed into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lukebrdn
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #96