Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@checkdigit/github-actions",
"version": "4.0.1",
"version": "4.0.2",
"description": " Provides supporting operations for github action builds.",
"homepage": "https://github.com/checkdigit/github-actions#readme",
"bugs": {
Expand Down
11 changes: 1 addition & 10 deletions src/check-imports/packages-not-allowed.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { describe, it } from 'node:test';

import * as semver from 'semver';

import notAllowed, { SECURITY_RISK } from './packages-not-allowed.ts';
import notAllowed from './packages-not-allowed.ts';

describe('packages not allowed', async () => {
it('contains a list of names, valid ranges, and reasons', async () => {
Expand All @@ -15,13 +15,4 @@ describe('packages not allowed', async () => {
assert.ok(reason.length > 10); // Ten is an arbitrary length to ensure a full sentence used in the reason.
});
});
it('contains axios as a fully blocked dependency', async () => {
assert.ok(
notAllowed.some(
([name, range, reason]) =>
name === 'axios' && range === '*' && reason === SECURITY_RISK,
),
'Should contain axios@* as not allowed',
);
});
});
5 changes: 0 additions & 5 deletions src/check-imports/packages-not-allowed.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@ export type NotAllowed = [Name, Range, Reason];
// const UNSTABLE =
// 'Higher versions are unstable and break tests in Check Digit services. This can be removed from the Not Allowed list when stability improves.';

export const SECURITY_RISK =
'Blocked by security policy due to security concerns'; /*
This is the list of packages that are not allowed to be imported.
*/
const notAllowed: NotAllowed[] = [
// ['@aws-sdk/client-*', '>3.387.0', UNSTABLE], // example of an unstable package
['axios', '*', SECURITY_RISK],
];

export default notAllowed;
Loading