feat: add GitHub test session metadata [ship]#1378
Merged
Conversation
thebiglabasky
added
build
The gate only matched the exact lowercase string 'true', so a user exporting TRUE or 1 got a silent no-op. Accept true/1 case-insensitively (trimmed); everything else still disables the github metadata block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thebiglabasky
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional GitHub Actions metadata to CLI test-session payloads so detached
checkly testandcheckly triggerruns can be associated with a GitHub workflow run.The CLI now:
CHECKLY_GITHUB_*environment variables only whenCHECKLY_GITHUB_REPORT=truerepoInfo.githubCHECKLY_GITHUB_SHAandCHECKLY_GITHUB_REPOSITORYfor the existing repo info fields when neededWhy
This supports the packaged GitHub Action flow where the Action can pass trusted workflow metadata to the backend, while direct
npx checkly ...usage remains unchanged unless users explicitly set the Checkly-scoped env vars.Validation
pnpm exec vitest --run src/services/__tests__/util.spec.ts src/rest/__tests__/test-sessions.spec.ts --reporter=verbosepnpm run lint -- packages/cli/src/services/util.ts packages/cli/src/rest/test-sessions.ts packages/cli/src/services/__tests__/util.spec.ts packages/cli/src/rest/__tests__/test-sessions.spec.tsLinear