fix(reporters): don't render green assertions on a request error; add gRPC/SSL detail [SIM-286]#1386
Closed
danielpaulus wants to merge 1 commit into
Closed
Conversation
… gRPC/SSL detail [SIM-286] When a check result carries a requestError, no assertion was actually evaluated, yet the test reporter still printed every assertion as a green check for SSL/gRPC/traceroute (unlike API/DNS/TCP/ICMP). Suppress the Assertions block when requestError is set. Also: humanize gRPC assertion source labels, render gRPC response time, and add an explicit SSL response-time reason line plus a security-baseline verdict line. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NC9pESYE5wGqy5TKRzufyc
Contributor
Author
|
Superseded by #1391 (SIM-286 + SIM-287 combined into one PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIM-286
Fixes a misleading
checkly testrender plus a few detail gaps for the new monitor types. Targets thefeat/cli-pertype-result-renderingbranch (#1362) since it fixes that feature.requestError, nothing was evaluated, but the reporter still printed every assertion as green ✔ for SSL/gRPC/traceroute (the API/DNS/TCP/ICMP branches already guard this). Now the Assertions block is suppressed whenrequestErroris set.GRPC_STATUS_CODE…).timingPhases.total).Baseline: <verdict> (grade …)line.Tests
reporters/util.spec.ts: assertion suppression underrequestError, gRPC labels + response time, SSL baseline + reason lines. Snapshot updated.Verified live
SSL request-error now shows no assertion block; SSL happy-path renders
Baseline: pass (grade A-).🤖 Generated with Claude Code
https://claude.ai/code/session_01NC9pESYE5wGqy5TKRzufyc