Skip to content

build-master.py - fix ssl not working for 7.1 version#324

Merged
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow
Mar 31, 2026
Merged

build-master.py - fix ssl not working for 7.1 version#324
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow

Conversation

@david-ruiz-cko
Copy link
Copy Markdown
Contributor

This pull request significantly improves the reliability and robustness of the PHP 7.1 build process on Windows by overhauling how OpenSSL and Composer are configured and tested. The changes introduce comprehensive checks, more resilient fallbacks, and multiple repository options to ensure builds succeed even when SSL support is problematic.

PHP 7.1 OpenSSL setup and configuration improvements:

  • Replaces the previous OpenSSL setup with a more comprehensive approach: downloads specific VC14-compatible OpenSSL DLLs for PHP 7.1, attempts multiple download sources, and falls back to Windows installers if needed. Adds extensive DLL copy logic and cleanup.
  • Enhances PHP configuration: enables/disables extensions as needed, adds robust SSL and fallback configuration sections to php.ini, and ensures CA bundles are downloaded from multiple sources (with minimal fallback if all fail).
  • Implements thorough testing of OpenSSL functionality (extension loading, HTTPS wrapper, SSL context creation) and applies a comprehensive fallback (disabling OpenSSL, enabling cURL, HTTP-only mode) if any test fails.

Composer install and repository configuration enhancements:

  • Refactors Composer install step for PHP 7.1 on Windows to dynamically detect SSL capability: configures Composer for secure HTTPS repositories if OpenSSL works, or switches to HTTP-only mode with multiple repository fallbacks and additional Composer optimizations if not.
  • Adds detailed diagnostic output and displays the final Composer configuration for easier troubleshooting and transparency.

@david-ruiz-cko david-ruiz-cko requested a review from a team March 31, 2026 12:14
@sonarqubecloud
Copy link
Copy Markdown

@david-ruiz-cko david-ruiz-cko merged commit 63febfa into master Mar 31, 2026
6 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/fix-build-master-windows-flow branch March 31, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants