Skip to content

build-master.yml - try to fix php 7.1 version for windows#325

Merged
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow
Mar 31, 2026
Merged

build-master.yml - try to fix php 7.1 version for windows#325
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow

Conversation

@david-ruiz-cko
Copy link
Copy Markdown
Contributor

This pull request updates the OpenSSL DLL setup and fallback logic for PHP 7.1 on Windows in the GitHub Actions workflow. The changes improve reliability by introducing multiple download sources, better error handling, and clearer configuration for both SSL-enabled and HTTP-only modes.

OpenSSL DLL download and installation improvements:

  • Replaces a single ZIP download with multiple direct DLL sources and a fallback to several installer URLs, increasing the chance of a successful setup. The script now tries to download DLLs individually and only falls back to installers if all direct downloads fail.

Configuration and fallback enhancements:

  • Updates the way newlines are added to php.ini (now using an empty string instead of "`n") and clarifies user agent strings for both fallback and HTTP-only configurations for consistency and clarity. [1] [2] [3]
  • Simplifies the SSL context creation test to only check for the existence of the stream_context_create function, making the test more robust and less error-prone.

@david-ruiz-cko david-ruiz-cko requested a review from a team March 31, 2026 12:37
@sonarqubecloud
Copy link
Copy Markdown

@david-ruiz-cko david-ruiz-cko merged commit daa5eb0 into master Mar 31, 2026
6 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/fix-build-master-windows-flow branch March 31, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants