Skip to content

build-master.yml - eliminated windows php 7.1 version test due to inc…#326

Merged
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow
Mar 31, 2026
Merged

build-master.yml - eliminated windows php 7.1 version test due to inc…#326
david-ruiz-cko merged 1 commit intomasterfrom
feature/fix-build-master-windows-flow

Conversation

@david-ruiz-cko
Copy link
Copy Markdown
Contributor

This pull request simplifies the GitHub Actions workflow for building and testing across multiple PHP versions and operating systems. The main focus is on streamlining the matrix configuration and removing complex, error-prone workarounds for PHP 7.1 on Windows, resulting in a more maintainable and consistent CI setup.

CI Matrix and Build Process Simplification:

  • The build matrix in .github/workflows/build-master.yml is now explicitly defined using the include strategy, allowing for precise control over which PHP versions are tested on which OS. Notably, PHP 7.1 is excluded from Windows builds due to SSL compatibility issues.

  • The previously complex and fragile PowerShell logic for handling OpenSSL in PHP 7.1 on Windows has been removed. The workflow now simply enables the openssl extension where possible, without attempting to patch or work around missing DLLs or CA bundles.

Composer Setup Streamlining:

  • The special-case logic for validating Composer and installing dependencies on PHP 7.1/Windows (including HTTP-only fallbacks and repeated repository configuration attempts) has been eliminated. Composer validation and installation now use standard commands for all environments, with only a minimal distinction for PHP 7.1 regarding dependency installation.

Dependency Management Improvements:

  • For PHP 7.4 and newer, the workflow now ensures up-to-date versions of key dependencies (guzzlehttp/guzzle, guzzlehttp/promises, phpunit/phpunit) are installed, improving test coverage and compatibility.

These changes collectively reduce maintenance overhead, improve reliability, and make the workflow easier to understand and extend.…ompatibilities

@david-ruiz-cko david-ruiz-cko requested a review from a team March 31, 2026 13:10
@sonarqubecloud
Copy link
Copy Markdown

@david-ruiz-cko david-ruiz-cko merged commit 99b0d12 into master Mar 31, 2026
6 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/fix-build-master-windows-flow branch March 31, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants