Skip to content

fix(setups): document pay by bank under the paybybank key - #220

Merged
armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1717-paybybank-key
Oct 15, 2026
Merged

armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1717-paybybank-key

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
The Payment Setup API names the Pay by Bank method paybybank. PayByBankPaymentMethod existed but nothing documented which key to send it under, so it could not be used. This PR documents the paybybank key and adds the risk object (enabled).

Changes

  • setups/pay_by_bank_payment_method.rb: documents the payment_methods.paybybank key and how to send and read it, so the class is usable
  • setups/payment_setup_risk.rb (new): enabled; required in payments.rb
  • setups/payment_setups_client.rb: create and update docs list :paybybank and :risk
  • setup_payment_methods_serialization_spec.rb: literal key, response action, risk serialization

API Reference

Breaking changes
None.

README
No change needed.

Local CI
Ran build-pull-request (Ruby 3.1) with act against the sandbox: 830 examples, 2 failures, both in transfers_integration_spec.rb (the sandbox answers 422 to POST /transfers). Unrelated to this change; master passed on 2026-10-08.

@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 14, 2026 12:12
@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The change only adds documentation, new Ruby data-class stubs (PaymentSetupRisk with a single attr_accessor), and spec coverage for already-existing endpoints and serialization paths, with no new external integrations, no persisted data, no auth changes, and no new background processes.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 5


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 14, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The change only adds documentation, new Ruby data-class stubs (PaymentSetupRisk with a single attr_accessor), and spec coverage for already-existing endpoints and serialization paths, with no new external integrations, no persisted data, no auth changes, and no new background processes. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

The Payment Setup API names the Pay by Bank method paybybank; the old key
is ignored without an error. Also adds the risk object (enabled).
@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only adds documentation comments, a small new plain data class (PaymentSetupRisk with a single attr_accessor), and tests — it reuses existing serialization paths and endpoints without adding new external integrations, persisted data, auth changes, or background workers.

Operational gates

  • ✅ jira_ticket (INT-1717)
  • ✅ independent_review

Files analysed: 5


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extension — The PR only adds documentation comments, a small new plain data class (PaymentSetupRisk with a single attr_accessor), and tests — it reuses existing serialization paths and endpoints without adding new external integrations, persisted data, auth changes, or background workers. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only adds documentation comments, a new simple data-class (PaymentSetupRisk with one attr_accessor), and tests for existing serialization paths—it introduces no new endpoints, external integrations, persisted data, auth changes, or background workers, and is a natural extension of already-existing PayByBank and setup abstractions.

wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@armando-rodriguez-cko
armando-rodriguez-cko merged commit 507977c into master Oct 15, 2026
5 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the fix/INT-1717-paybybank-key branch October 15, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants