Repository navigation
fix(setups): document pay by bank under the paybybank key - #220
Conversation
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 5 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
The Payment Setup API names the Pay by Bank method paybybank; the old key is ignored without an error. Also adds the risk object (enabled).
b8220f6 to
552c0e9
Compare
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 5 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The PR only adds documentation comments, a new simple data-class (PaymentSetupRisk with one attr_accessor), and tests for existing serialization paths—it introduces no new endpoints, external integrations, persisted data, auth changes, or background workers, and is a natural extension of already-existing PayByBank and setup abstractions.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…



Summary
The Payment Setup API names the Pay by Bank method
paybybank.PayByBankPaymentMethodexisted but nothing documented which key to send it under, so it could not be used. This PR documents thepaybybankkey and adds theriskobject (enabled).Changes
setups/pay_by_bank_payment_method.rb: documents thepayment_methods.paybybankkey and how to send and read it, so the class is usablesetups/payment_setup_risk.rb(new):enabled; required inpayments.rbsetups/payment_setups_client.rb: create and update docs list:paybybankand:risksetup_payment_methods_serialization_spec.rb: literal key, responseaction,riskserializationAPI Reference
POST /payments/setups: payment_methods.paybybank, riskPUT /payments/setups/{id}: payment_methods.paybybank, riskGET /payments/setups/{id}Breaking changes
None.
README
No change needed.
Local CI
Ran
build-pull-request(Ruby 3.1) with act against the sandbox: 830 examples, 2 failures, both intransfers_integration_spec.rb(the sandbox answers 422 toPOST /transfers). Unrelated to this change; master passed on 2026-10-08.